Skip to content

fix: failed to build instrument hooks on bare metal runner#55

Merged
not-matthias merged 2 commits intomainfrom
cod-2306-failed-to-build-instrument-hooks-on-bare-metal-runner
Mar 13, 2026
Merged

fix: failed to build instrument hooks on bare metal runner#55
not-matthias merged 2 commits intomainfrom
cod-2306-failed-to-build-instrument-hooks-on-bare-metal-runner

Conversation

@not-matthias
Copy link
Member

Fixes #53

Copy link

@GuillaumeLagrange GuillaumeLagrange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses build failures on bare-metal runners by ensuring the Go runner can compile the cgo-based instrumentation hooks (fixes #53).

Changes:

  • Add an early check that a C compiler is available before proceeding with overlay/hook setup.
  • Force CGO_ENABLED=1 for the go test invocation so the cgo-based overlay file isn’t silently excluded.
  • Add agent-facing documentation (AGENTS.md) and update CLAUDE.md accordingly.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 3 comments.

File Description
go-runner/src/runner/mod.rs Adds C compiler preflight checks and forces CGO_ENABLED=1 for benchmark builds.
AGENTS.md Documents project architecture, runner modes, and build/test workflows.
CLAUDE.md Points Claude/agents to the agent documentation.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

You can also share your feedback on Copilot code review. Take the survey.

@codspeed-hq
Copy link

codspeed-hq bot commented Mar 13, 2026

Merging this PR will not alter performance

✅ 48 untouched benchmarks
⏩ 1 skipped benchmark1


Comparing cod-2306-failed-to-build-instrument-hooks-on-bare-metal-runner (9e139ac) with main (9ab56f8)

Open in CodSpeed

Footnotes

  1. 1 benchmark was skipped, so the baseline result was used instead. If it was deleted from the codebase, click here and archive it to remove it from the performance reports.

@not-matthias not-matthias force-pushed the cod-2306-failed-to-build-instrument-hooks-on-bare-metal-runner branch from 6df525d to 9e139ac Compare March 13, 2026 16:37
@not-matthias not-matthias merged commit 9e139ac into main Mar 13, 2026
20 checks passed
@not-matthias not-matthias deleted the cod-2306-failed-to-build-instrument-hooks-on-bare-metal-runner branch March 13, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Failed to build instrument hooks on bare metal runner

3 participants